Added support for http proxy

swapdesai commented 2 years ago

Summary

Added support for http proxy to the connector configuration. This allows the user to add proxy host details when using the connector within a corporate environment having proxy host.

Changes

Added support for http proxy with the following connector configuration

aep.connection.proxy.host: address of the proxy host to connect through
aep.connection.proxy.port: port of the proxy host to connect through
aep.connection.proxy.user: username for the proxy host
aep.connection.proxy.password: password for the proxy host

Relevant Documentation

DEVELOPER_GUIDE.md

How Has This Been Tested?

Added a new test case aepSinkConnectorTestViaProxy() to the existing test suite. To execute this test case, have setup a new mock extention wiremockExtensionViaProxy which acts as a proxy server to redirect the request to the actual wiremockExtension.

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[ ] I have signed the Adobe Open Source CLA.
[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

vivetiwa commented 2 years ago

thanks @swapdesai! for the PR. I think though we can use system variable to enable connector to send request to proxy server first but PR would be helpful if someone want to configure different proxy server for each connector instance.

nipunnair commented 2 years ago

Please note that your PR is included in https://github.com/adobe/experience-platform-streaming-connect/pull/28.

swapdesai commented 2 years ago

@nipunnair Disappointing to know that you created a new PR.

swapdesai commented 2 years ago

Also, the release tag (0.0.8) does not match the SemVer (0.0.7)

nipunnair commented 2 years ago

@nipunnair Disappointing to know that you created a new PR.

@swapdesai Can you explain why the disappointment - lets make it smoother next time. We were asked by our consulting team on making this change available faster in the build. Your changes are included as is ( check commit history ), we added a configuration to override the proxy hosts as @vivetiwa pointed out.

Apologies for any hard feelings!

vivetiwa commented 2 years ago

Closing this PR as all the commits/changes are added as part of PR : https://github.com/adobe/experience-platform-streaming-connect/pull/28

adobe / experience-platform-streaming-connect