adobe / helix-website

The Helix website https://www.aem.live/
https://www.aem.live
Apache License 2.0
26 stars 41 forks source link

Conversion checkpoint defined via url parameter is lost when selecting any of the facet. #638

Closed vdua closed 1 month ago

vdua commented 3 months ago

In rum explorer there is a method to redefine conversions via the conversion.<>= url parameter. But when we select another facet from the sidebar, we remove this url parameter leading to loosing this information and hence sharing that URL leads to different data being visible to that user.

Expected Behaviour

The url parameter should not be removed and sharing the URL should show the same data to each user (given that they have the domain key)

Actual Behaviour

The URL parameter is removed.

Reproduce Scenario (including but not limited to)

Steps to Reproduce

  1. Open this URL (update the domain and domain key as per the requirement) https://www.aem.live/tools/rum/explorer.html?domain=a.com&filter=&view=year&metrics=all&domainkey=incognito&conversion.checkpoint=formsubmit
  2. Choose any checkpoint and check the data that that is being visible in the engagement card
  3. Copy the URL from the address bar and open it in a different tab.

Expected: The engagement card should show the same data in both the tabs but it doesn't

Actual: The engagement card shows the different data on both the tabs even though the URL remains the same.

Platform and Version

Sample Code that illustrates the problem

Logs taken while reproducing problem

vdua commented 3 months ago

@lkrapf This is fixed in oversight though. It seems like it was removed intentionally here. Please close it if it was intentional otherwise I will raise a PR to fix it.

[1] https://github.com/adobe/helix-website/commit/1a7278e85cf7e187495d7e2754d12d90d1f4a7ac#diff-8a25fa49f3114e66436978f3e97cd5b53b46229b376c581da0154b1c622eedbaL296