adobe / react-spectrum

A collection of libraries and tools that help you build adaptive, accessible, and robust user experiences.
https://react-spectrum.adobe.com
Apache License 2.0
13.07k stars 1.14k forks source link

pass onContextMenu in react-aria-components `Tab` #7197

Open vovsemenv opened 1 month ago

vovsemenv commented 1 month ago

Provide a general summary of the feature here

I creating customContext menu and need to pass onConextMenuto the Tab

๐Ÿค” Expected Behavior?

<BaseTab
      onContextMenu={item.contextMenu && menuPosition.onContextMenu}
 >

๐Ÿ˜ฏ Current Behavior

props doesn't pass to tab

๐Ÿ’ Possible Solution

No response

๐Ÿ”ฆ Context

custom context menu

๐Ÿ’ป Examples

No response

๐Ÿงข Your Company/Team

No response

๐Ÿ•ท Tracking Issue

No response

LFDanLu commented 1 month ago

We could consider doing this but we'll need to be intentional in where we else we'd want to add this and if there are any other props we'd considered passing through. Will take some discussion and may be low on our priority list unless we have an internal need for it or if requested more widely by others.

anmol-fzr commented 1 month ago

@LFDanLu Hey I would like to work on this issue, please assign this to me.

LFDanLu commented 4 weeks ago

@anmol-fzr Hi, thank you for the interest! The team still needs to discuss the stuff I mentioned above in my previous comment before we feel comfortable accepting a PR for this, sorry about that.