WIP: hash macro class names - Githubissues

adobe / react-spectrum

A collection of libraries and tools that help you build adaptive, accessible, and robust user experiences.

https://react-spectrum.adobe.com

Apache License 2.0

13.11k stars 1.14k forks source link

WIP: hash macro class names #7349

Closed reidbarber closed 2 weeks ago

reidbarber commented 2 weeks ago

Related to https://github.com/adobe/react-spectrum/pull/7304

Stylesheet diff:

Current: original size: 78615 / gzipped size: 13987
Hashed: original size: 93802 / gzipped size: 17664

Class names on Button diff:

Current: original size: 482 / gzipped size: 314
Hashed: original size: 887 / gzipped size: 491

✅ Pull Request Checklist:

[ ] Included link to corresponding React Spectrum GitHub Issue.
[ ] Added/updated unit tests and storybook for this change (for new code or code which already has tests).
[ ] Filled out test instructions.
[ ] Updated documentation (if it already exists for this component).
[ ] Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

reidbarber commented 2 weeks ago

Closing for now in favor of simply preventing S1/S2 style macro collision. Will re-visit if needed later for preventing collisions between multiple S2 versions.