adobe / spectrum-css

The standard CSS implementation of the Spectrum design language.
http://opensource.adobe.com/spectrum-css/
Apache License 2.0
1.19k stars 194 forks source link

[clearbutton]: Correct WHCM styling for search clear button in search input UI #1461

Open PreetiNagal opened 2 years ago

PreetiNagal commented 2 years ago

Expected Behaviour

Search clear button should not overlap with search input text field

Actual Behaviour

Search clear button overlaps with search input text field causing UI experience doesn't look good. @jnurthen

Reproduce Scenario (including but not limited to)

check search input UI experience in WHCM

Steps to Reproduce

Platform and Version

Windows and all

Sample Code that illustrates the problem

Logs taken while reproducing problem

synced to jira: https://jira.corp.adobe.com/browse/CSS-203

jnurthen commented 2 years ago
--spectrum-clearbutton-fill-background-color: ButtonFace;
--spectrum-clearbutton-fill-background-color-disabled: ButtonFace;
--spectrum-clearbutton-fill-background-color-down: ButtonFace;
--spectrum-clearbutton-fill-background-color-hover: ButtonFace;
--spectrum-clearbutton-fill-background-color-key-focus: ButtonFace;

should all be transparent not ButtonFace.

@pfulton I suggest this can wait until the core token work.

pfulton commented 2 years ago

@jnurthen thanks James!

@PreetiNagal thank you for reporting this. We'll get it into our backlog.