fix(slider): update slider config to process the tick css correctly

Rajdeepc commented 3 weeks ago

Description

sp-slider tick UI was distorted due to addition of a new attribute from the latest foundation release of @spectrum-css/slider where the spectrum-config was not parsing the css correctly and was overriding the .controls display attribute from inline-block to flex

Related issue(s)

https://jira.corp.adobe.com/browse/SWC-584

Motivation and context

How has this been tested?

[ ] Documentation Site
1. Go here

Screenshots (if appropriate)

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Checklist

[x] I have signed the Adobe Open Source CLA.
[x] My code follows the code style of this project.
[ ] If my change required a change to the documentation, I have updated the documentation in this pull request.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.
[x] I have reviewed at the Accessibility Practices for this feature, see: Aria Practices

Best practices

This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against main.

github-actions[bot] commented 3 weeks ago

Branch preview

Visual regression test results

github-actions[bot] commented 3 weeks ago

Tachometer results

Chrome

## slider [_permalink_](#user-content-slider) ### test-basic | Version | Bytes | Avg Time | vs remote | vs branch | |---|---|---|---|---| | npm latest | 742 kB | 78.37ms - 80.80ms | - | faster ✔
2% - 7%
1.81ms - 5.77ms | | branch | 717 kB | 81.82ms - 84.94ms | slower ❌
2% - 7%
1.81ms - 5.77ms | - |

Firefox

## slider [_permalink_](#user-content-slider) ### test-basic | Version | Bytes | Avg Time | vs remote | vs branch | |---|---|---|---|---| | npm latest | 742 kB | 163.79ms - 173.57ms | - | unsure 🔍
-7% - +1%
-11.38ms - +2.50ms | | branch | 717 kB | 168.19ms - 178.05ms | unsure 🔍
-2% - +7%
-2.50ms - +11.38ms | - |

coveralls commented 3 weeks ago

Pull Request Test Coverage Report for Build 11741716272

Details

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 98.194%

Totals
Change from base Build 11739806566:	0.0%
Covered Lines:	32314
Relevant Lines:	32732

💛 - Coveralls

github-actions[bot] commented 3 weeks ago

Lighthouse scores

Category	Latest (report)	Main (report)	Branch (report)
Performance	0.99	0.99	0.99
Accessibility	1	1	1
Best Practices	1	1	1
SEO	1	0.92	0.92
PWA	1	1	1

What is this?

[Lighthouse](https://github.com/GoogleChrome/lighthouse) scores comparing the documentation site built from the PR ("Branch") to that of the production documentation site ("Latest") and the build currently on main ("Main"). Higher scores are better, but *note that the SEO scores on Netlify URLs are artifically constrained to 0.92.*

Transfer Size

Category	Latest	Main	Branch
Total	250.779 kB	236.435 kB 🏆	236.672 kB
Scripts	60.764 kB	54.082 kB 🏆	54.249 kB
Stylesheet	54.015 kB	47.956 kB	47.922 kB 🏆
Document	6.207 kB	5.441 kB 🏆	5.493 kB
Font	126.824 kB	126.606 kB 🏆	126.659 kB

Request Count

Category	Latest	Main	Branch
Total	52	52	52
Scripts	41	41	41
Stylesheet	5	5	5
Document	1	1	1
Font	2	2	2

adobe / spectrum-web-components