github-actions[bot]
commented
2 weeks ago Branch preview
Review the following VRT differences
When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:
- Spectrum | Light | Medium | LTR
- Spectrum | Dark | Large | RTL
- Express | Light | Medium | LTR
- Express | Dark | Large | RTL
- Spectrum-two | Light | Medium | LTR
- Spectrum-two | Dark | Large | RTL
- High Contrast Mode | Medium | LTR
If the changes are expected, update the current_golden_images_cache hash in the circleci config to accept the new images. Instructions are included in that file.
If the changes are unexpected, you can investigate the cause of the differences and update the code accordingly.
coveralls
nikkimk
Rajdeepc
Description
<sp-button>and<sp-action-button>withhrefcould not be activated by mouse-click or screenreader click.ButtonBaseto allow clicks when there is anhrefattribute set.<sp-button>and<sp-action-button>.<sp-action-button>with anhrefattribute.Related issue(s)
4576
How has this been tested?
[ ]
<sp-button> mouse click[ ]
<sp-button> screenreader click[ ]
<sp-action-button> mouse click[ ]
<sp-action-button> screenreader click[x] Did it pass in Desktop?
[ ] Did it pass in Mobile?
[ ] Did it pass in iPad?
Screenshots (if appropriate)
Types of changes
Checklist
Best practices
This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against
main.