Skia m116 core support - Githubissues

HinTak commented 1 year ago

Description

This is most of required to build just the library-only part of current svg-native-viewer against current Skia (m116).

Related Issue

It includes the fix the #186, and partially addresses #187. I no longer care about the examples, so I have not addessed the example part of the problems listed in #187.

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have signed the Adobe Open Source CLA.
[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

HinTak commented 1 year ago

It looks like your CI is broken. Anyway, I am curious what version of skia you tests with. The example code fails building on entry as far as I can see from the git log.

HinTak commented 10 months ago

Replaced by #199 together with #198