adonisjs / lucid

AdonisJS SQL ORM. Supports PostgreSQL, MySQL, MSSQL, Redshift, SQLite and many more

https://lucid.adonisjs.com/

MIT License

1.02k stars 189 forks source link

replaced Promise.all with for loop #1028

Closed mdsadique-inam closed 1 month ago

mdsadique-inam commented 1 month ago

the Promise.all creates the deadlock causing the command db:truncate to throw error deadlock detected

🔗 Linked issue

1027

❓ Type of change

[x] 🐞 Bug fix (a non-breaking change that fixes an issue)
[ ] 👌 Enhancement (improving an existing functionality like performance)
[ ] ✨ New feature (a non-breaking change that adds functionality)
[ ] ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Replaced Promise.all with for loop in db_truncate.ts resolves #1027

📝 Checklist

[x] I have linked an issue or discussion.
[x] I have updated the documentation accordingly.

thetutlage commented 1 month ago

Please first share a reproduction of what exactly the issue is. We cannot change code that is been working for years for everyone.