search

adopted-ember-addons / ember-light-table

Lightweight, contextual component based table for Ember
http://adopted-ember-addons.github.io/ember-light-table/
MIT License
312 stars 131 forks source link

Create a base ember-twiddle for showcasing issues #442

Open buschtoens opened 7 years ago

buschtoens commented 7 years ago

As suggested in https://github.com/offirgolan/ember-light-table/pull/441#discussion_r123591773

An official base ember-twiddle would be super useful to quickly prototype new ideas or demonstrate bugs / issues.

buschtoens commented 7 years ago

Should we include any other addons by default? Good candidates:

Should we provide multiple routes with different base setups (similar to the dummy app) or only the one "classic" minimal example?

What about styling?

Should we include instructions in the twiddle itself? If so, which?

offirgolan commented 7 years ago

I think a good setup would just be a twiddle with ember-light-table with a basic table and simple data. We shouldnt depend on all those extra dependencies since they could potentially introduce some complications in the future (prolly not but hey... you never know). The more vanilla the easier it will be for us to debug 😄

buschtoens commented 7 years ago

I think a good setup would just be a twiddle with ember-light-table with a basic table and simple data.

By "simple data" you probably mean static fixtures (const rows = [ ... ]) and not a pre-configured Mirage?

I believe including Mirage is a good idea, because users tend to encounter problems while actually interacting with an API / Ember Data with #423 and #272 being examples. Setting up Mirage in Ember Twiddle is a pain we can alleviate. Here's the Mirage boilerplate Twiddle.

I understand that you want to keep the base Twiddle as slim as possible, so a second Twiddle with Mirage pre-installed could be a nice addition.

offirgolan commented 7 years ago

Very true! ELT + Mirage twiddle sounds good to me.