search

adopted-ember-addons / ember-light-table

Lightweight, contextual component based table for Ember
http://adopted-ember-addons.github.io/ember-light-table/
MIT License
312 stars 131 forks source link

Deprecations #819

Open eric-g-97477 opened 1 year ago

eric-g-97477 commented 1 year ago

While building, I am getting the following deprecation warnings with 3.0.0 beta.1

DEPRECATION: Using {{attrs}} to reference named arguments has been deprecated. {{attrs.id}} should be updated to {{@id}}. ('ember-light-table/components/light-table.hbs' @ L3:C10) [deprecation id: attrs-arg-access] See https://deprecations.emberjs.com/v3.x/#toc_attrs-arg-access for more details. DEPRECATION: Using {{attrs}} to reference named arguments has been deprecated. {{attrs.id}} should be updated to {{@id}}. ('ember-light-table/components/light-table.hbs' @ L11:C20) [deprecation id: attrs-arg-access] See https://deprecations.emberjs.com/v3.x/#toc_attrs-arg-access for more details. DEPRECATION: Using {{attrs}} to reference named arguments has been deprecated. {{attrs.id}} should be updated to {{@id}}. ('ember-light-table/components/light-table.hbs' @ L20:C20) [deprecation id: attrs-arg-access] See https://deprecations.emberjs.com/v3.x/#toc_attrs-arg-access for more details. DEPRECATION: Using {{attrs}} to reference named arguments has been deprecated. {{attrs.id}} should be updated to {{@id}}. ('ember-light-table/components/light-table.hbs' @ L29:C20) [deprecation id: attrs-arg-access] See https://deprecations.emberjs.com/v3.x/#toc_attrs-arg-access for more details.

Can they be fixed easily and a beta.2 released?

I am building with Ember 3.28.

vstefanovic97 commented 1 year ago

I created a PR with the fix if someone can just run the workflow and merge it https://github.com/adopted-ember-addons/ember-light-table/pull/824