search

adopted-ember-addons / ember-stripe-elements

A simple Ember wrapper for Stripe Elements
https://ember-stripe-elements.netlify.com
MIT License
19 stars 23 forks source link

ADD confirmCardPayment function #2

Closed DavidPhilip closed 4 years ago

st-h commented 4 years ago

Thank you for the PR. I have just been looking through the sources, as I am not very familiar with the implementation details of this addon yet. I think, if we add the confirmCardPayment function we should also add it to the stripe-mock.

If you could add some tests as well, that would be awesome. If not, please open an issue to track adding tests.

rex-escario commented 4 years ago

any update for this pr?

st-h commented 4 years ago

@rex-escario the last update has been 13 hours ago. Is there anything particular you were looking for?

DavidPhilip commented 4 years ago

@st-h Should be good to go now 👍

st-h commented 4 years ago

@DavidPhilip thanks a lot

st-h commented 4 years ago

released as @adopted-ember-addons/ember-stripe-elements@1.0.0-rc.1

rex-escario commented 4 years ago

sweet, thanks.