search

adopted-ember-addons / validated-changeset

Buffering changes to form data
MIT License
36 stars 27 forks source link

rollbackInvalid removes valid changes #177

Closed vstefanovic97 closed 2 years ago

vstefanovic97 commented 2 years ago

Steps to reproduce

  1. Create nested property on a changeset
  2. Make it fail validation
  3. Set it to a valid value and validate
  4. Call rollbackInvalid()
  5. Observe that the now valid property had been removed from the changesets changes.

I have created a PR with a fix for this, also added a test case that can be reviewed for reproduction (without the fix the test will fail) https://github.com/validated-changeset/validated-changeset/pull/176

snewcomer commented 2 years ago

1.3.3!