search

adoptium / temurin-build

Eclipse Temurin™ build scripts - common across all releases/versions
Apache License 2.0
1.03k stars 249 forks source link

Demo folder included #980

Closed marschall closed 4 years ago

marschall commented 5 years ago

I'm not sure whether this is intentional or not but the OpenJDK builds by AdoptOpenJDK include a demo/ folder while the OpenJDK builds by Oracle do not. Personally I don't see much use from the demos and certainly would not want to deploy them on a production server. Maybe the can be offered as a separate download.

Zulu interestingly does include the demo/ folder.

gdams commented 5 years ago

Admittedly it's not very big (see below) but makes sense for it to be removed from production binaries

➜  Home du -h demo 
 24K    demo/nbproject/scripting/jconsole-plugin/nbproject
 32K    demo/nbproject/scripting/jconsole-plugin
 32K    demo/nbproject/scripting
 24K    demo/nbproject/management/FullThreadDump/nbproject
 32K    demo/nbproject/management/FullThreadDump
 24K    demo/nbproject/management/JTop/nbproject
 32K    demo/nbproject/management/JTop
 24K    demo/nbproject/management/VerboseGC/nbproject
 32K    demo/nbproject/management/VerboseGC
 24K    demo/nbproject/management/MemoryMonitor/nbproject
 32K    demo/nbproject/management/MemoryMonitor
128K    demo/nbproject/management
 24K    demo/nbproject/jfc/FileChooserDemo/nbproject
 32K    demo/nbproject/jfc/FileChooserDemo
 24K    demo/nbproject/jfc/Font2DTest/nbproject
 32K    demo/nbproject/jfc/Font2DTest
 24K    demo/nbproject/jfc/TransparentRuler/nbproject
 32K    demo/nbproject/jfc/TransparentRuler
 24K    demo/nbproject/jfc/Metalworks/nbproject
 32K    demo/nbproject/jfc/Metalworks
 24K    demo/nbproject/jfc/TableExample/nbproject
 32K    demo/nbproject/jfc/TableExample
 24K    demo/nbproject/jfc/SwingApplet/nbproject
 32K    demo/nbproject/jfc/SwingApplet
 24K    demo/nbproject/jfc/SampleTree/nbproject
 32K    demo/nbproject/jfc/SampleTree
 24K    demo/nbproject/jfc/Notepad/nbproject
 32K    demo/nbproject/jfc/Notepad
256K    demo/nbproject/jfc
424K    demo/nbproject
200K    demo/jfc/Stylepad
 44K    demo/jfc/FileChooserDemo
 48K    demo/jfc/CodePointIM
 20K    demo/jfc/TransparentRuler
3.0M    demo/jfc/SwingSet2
 96K    demo/jfc/Metalworks
 64K    demo/jfc/TableExample
 48K    demo/jfc/SampleTree
 68K    demo/jfc/Notepad
1.7M    demo/jfc/J2Ddemo
5.3M    demo/jfc
5.7M    demo
gdams commented 5 years ago

TSC has voted to remove the Demo folder.

psoujany commented 4 years ago

I've raised a PR to remove demo folder. https://github.com/AdoptOpenJDK/openjdk-build/pull/1605