search

adriangb / asyncpg-trek

Simple migrations system for asyncpg
MIT License
8 stars 2 forks source link

Protocol modification #4

Closed euri10 closed 1 year ago

euri10 commented 1 year ago

I do not understand why we have to pass a asyncpg.Connection to plan, execute etc, when the AsyncpgBackend we previously instanciated has already one, but doesnt make use of it. Consider this a base for discussion, its entirely possible I missed something.

edit: it passes tests but mypy fails,

adriangb commented 1 year ago

Seems reasonable to me, let me see what's up with mypy

euri10 commented 1 year ago

closing for #5 which is way better