search

adrienemery / lnd-grpc-client

A python grpc client/async client for LND ⚡⚡⚡
MIT License
34 stars 20 forks source link

Kwargs, and additional subsystem support #30

Open kornpow opened 3 years ago

kornpow commented 3 years ago

This is a work-in-progress PR of the work I am doing to add support for additional LND subsystems, and enable usage of all variables in rpc calls, instead of having to manually add them to this code.

kornpow commented 3 years ago

I also starting using this library: git+ssh://git@github.com/wearefair/protobuf-to-dict, which is a nicer way to convert the data to a dictionary than using googles protobuf library.

kornpow commented 3 years ago

@adrienemery Think we can get this merged in? Im looking to do more consistent work on this repository

nickfarrow commented 2 years ago

I strongly support this PR, it would allow me to implement lightning address into my software (add_invoice takes required args). As well as numerous other advanced features. Is there anything i can do to help, what still needs work?

kornpow commented 2 years ago

I strongly support this PR, it would allow me to implement lightning address into my software (add_invoice takes required args). As well as numerous other advanced features. Is there anything i can do to help, what still needs work?

Check out my fork I actively maintain it

nickfarrow commented 2 years ago

I strongly support this PR, it would allow me to implement lightning address into my software (add_invoice takes required args). As well as numerous other advanced features. Is there anything i can do to help, what still needs work?

Check out my fork I actively maintain it

I have and it's fantastic. Do tou know if there is any way to install using pip from a requirements.txt. I've got a whole bunch of docker images and things that need that easy install and I haven't quite figure it out the proper way to install from a repo!

kornpow commented 2 years ago

I strongly support this PR, it would allow me to implement lightning address into my software (add_invoice takes required args). As well as numerous other advanced features. Is there anything i can do to help, what still needs work?

Check out my fork I actively maintain it

I have and it's fantastic. Do tou know if there is any way to install using pip from a requirements.txt. I've got a whole bunch of docker images and things that need that easy install and I haven't quite figure it out the proper way to install from a repo!

just ‘pip install lnd-grpc-client’ or add that line to your requirements.txt

‘pip install -r requirements.txt’

nickfarrow commented 2 years ago

just ‘pip install lnd-grpc-client’ or add that line to your requirements.txt

‘pip install -r requirements.txt’

AHH I didn't realise the name was different, fantastic thank you so much

ibz commented 2 years ago

@adrienemery Since @kornpow's version of lnd-grpc-client is now the usable one it would be nice if you would edit your project's README to mention that your version is not maintained anymore, direct people to @kornpow's and archive the project.

The issue is, it is very confusing for newcomers. It took me a while to try to make things work with your version just to realize there is another version that works.

adrienemery commented 2 years ago

@ibz - thanks for the suggestion. I agree and will update it. And thanks to @kornpow for continuing to move it forward 👍🏽.