search

adsabs / ADSIngestParser

Curation parser library
MIT License
0 stars 7 forks source link

fixed eLocator bug #100

Closed seasidesparrow closed 4 months ago

seasidesparrow commented 5 months ago

This fix captures eLocator into electronic_id in the case where <FirstPage> is included in the document but is one of["n/a", "no"]. I am also exporting the entire eLocator value, rather than[-5:]`; we can extract a substring for bibcode creation in an ADSIngestEnrichment.bibcodes special case. modified: adsingestp/parsers/wiley.py modified: tests/stubdata/output/wiley_jgra_57392.json modified: tests/stubdata/output/wiley_swe_21103.json modified: tests/test_wiley.py

codecov-commenter commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.43%. Comparing base (f2b8dad) to head (f98a696).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #100 +/- ## ========================================== + Coverage 90.25% 90.43% +0.17% ========================================== Files 25 25 Lines 2627 2624 -3 ========================================== + Hits 2371 2373 +2 + Misses 256 251 -5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.