search

aduth / Doom_CooldownPulse

A World of Warcraft addon that animates ability icons when they are available to be used after cooldown
MIT License
11 stars 7 forks source link

Added a new feature which now displays the icon shortly before the co… #7

Closed patrykdziurkowski closed 1 year ago

patrykdziurkowski commented 1 year ago

…oldown has finished loading, to let the user know it is about to come off cooldown or to account for human reaction times.

patrykdziurkowski commented 1 year ago

You're right about the step increment and the naming - I've added both these changes. Unfortunately naming it "Show Before Available Time" won't be enough to avoid increasing the width. And the height also needs increasing in order to accommodate for a brand new slider in the frame. As for my preferred handle, this one on GitHub will be ok. I committed these changes.

aduth commented 1 year ago

Unfortunately naming it "Show Before Available Time" won't be enough to avoid increasing the width. And the height also needs increasing in order to accommodate for a brand new slider in the frame.

Increasing the height makes sense. I tested to see how it works with the existing width, and it seems to be okay? Was there maybe something with your UI scale where it was still necessary to increase the width?

Here's how it looks in my game at the old width (220):

WoWScrnShot_041023_210056

patrykdziurkowski commented 1 year ago

Seems that font size is calculated based on monitor's width, so with different aspect ratios (i.e. ultrawide) the font size can appear bigger. I tested this and while the text is too big for 2560x1080, it fits just fine on 1920x1080. I found this post on WoW's forums: https://us.forums.blizzard.com/en/wow/t/combat-text-and-ultrawide-resolutions/271857

Changing the UI scale didn't affect the size in the slightest, since these are hardcoded values. 2560x1080 image 1920x1080 image

aduth commented 1 year ago

Gotcha, thanks for sharing that information about screen resolutions. Makes sense that the width would need to be increased 👍

aduth commented 1 year ago

Hey @patrykdziurkowski , I just published v1.5.0 of the addon to CurseForge, which includes this change. Thanks again for the pull request!

I don't have an active WoW subscription at the moment, so while I was able to test this in retail using a trial account, I couldn't verify the release for WoTLK classic. I pushed a beta version of v1.5.0 for WoTLK Classic if you'd like to test it out and let me know if everything is working, then I can publish a release version for that as well.

patrykdziurkowski commented 1 year ago

I don't have a high-level character on WotLK to test out different cooldowns, but I did test out the Stoneform dwarf racial on a low-level character and everything seemed to work well, including the new feature.

aduth commented 1 year ago

Thanks for testing it out! I'll go ahead and publish the release version of that as well.