search

advanced-cms / advanced-reviews

This is an Open Source add-on that improves the reviewing process and lets external users to view & review content items or whole projects without the need to access the Edit Mode. Created and maintained by Bartosz Sekuła and Grzegorz Wiecheć
Apache License 2.0
17 stars 15 forks source link

404 error on using editable link #202

Closed leonardofraga91 closed 3 years ago

leonardofraga91 commented 3 years ago

Hi, @barteksekula I'm facing the same problem above. I have implemented the class that enables editable links.

image

For all view links everything works fine. But when I try to create an 'Edit' link I always get the not found code.

Looking at the Browser's Network tab I found an URL that not seems mentioned anywhere. (.../externalpagereview/...) image

Can be this the problem?

Also @barteksekula from your previous comment I think you are mixing two different issues I was talking about -

  1. which you already fixed in later version, was the language branch code (en etc) was getting appended to url. I managed to fix this by using redirects until we had the version fix. So this is not a problem.
  2. The problem was only with pages for which content editors created preview in "edit" mode. Those when logged in with "ExternalReviewers" or any role always gave 404. As if the page never got created when clicked on Edit button using plugin only a url is generated with new guid each time but no page to view.

It seems exactly with the second case mentioned by [karorapepper ](https://github.com/advanced-cms/advanced-reviews/issues/53#issuecomment-537799596).

Informations: Advanced.CMS.AdvancedReviews = 0.9.0 EpiServer.CMS.Core = 11.20.3 - Dependency EpiServer.CMS.UI = 11.32.0 - Dependency

Can you give me some help with that?

leonardofraga91 commented 3 years ago

@barteksekula any help?

barteksekula commented 3 years ago

@leonardofraga91 any chance you could try to reproduce on a sample site from this repo? Or on a clean Alloy?

leonardofraga91 commented 3 years ago

I'll try to reproduce it, I'll let you know when I finish it. Thank you!

barteksekula commented 3 years ago

@leonardofraga91 I've just checked this on clean Alloy and everything works fine. I have ExternalReviewers group added: image

I have correct entries in my web.config (please make sure you had those - they are installed automatically with nuget but please check anyway)

<location path="externalContentReviews">
        <system.web>
            <authorization>
                <allow roles="ExternalReviewers" />
                <deny users="*" />
            </authorization>
        </system.web>
    </location><location path="EPiServer/advanced-cms.ExternalReviews">
        <system.web>
            <authorization>
                <allow roles="ExternalReviewers, WebEditors, WebAdmins, Administrators" />
                <deny users="*" />
            </authorization>
        </system.web>
    </location>

And I'm able to add an Edit link without a problem