pattivacek
commented
3 years ago * either gatesgarth branch should be created before this or maybe we should discuss if this LICENSE value is actually correct (e.g. MIT license files weren't renamed) and this recipe doesn't have own source, the initramfs itself should be covered by the recipe which provides whatever is set in INITRAMFS_IMAGE and kernel from virtual/kernel, but ostree-kernel-initramfs recipe is only metadata, so it might make sense to use MIT (as COPYING.MIT in the root of the repo) or MPL-2 like other metadata-only recipes in this layer (is it intentionally MPL-2 instead of more common for metadata MIT?):
I believe the license of the ostree-kernel-initramfs recipe is a mistake. I agree with you, it really should've been MIT or MPL-2.0. We historically preferred MPL-2.0 for aktualizr and the related recipes to encourage resharing of changes and improvements, but we used MIT for things that were intended to be examples that implementers would be completely free to build on. That's probably the right thing to do here.
It looks like you (@shr-project), @liuming50, @ricardosalveti, and @antznin have all contributed to this recipe. Any objections to changing it to MIT?
antznin
ricardosalveti
shr-project
liuming50
the license file was renamed in: https://git.openembedded.org/openembedded-core/commit/?id=5ecf139a31fa7bd813855f1235ea9f434fbcb2e0
and the build with latest oe-core is now failing with: WARNING: Could not copy license file TOPDIR/oe-core/meta/files/common-licenses/GPL-2.0 to TOPDIR/BUILD/work/raspberrypi3-oe-linux-gnueabi/ostree-kernel-initramfs/0.0.1-r0/license-destdir/ostree-kernel-initramfs/GPL-2.0: [Errno 2] No such file or directory: 'TOPDIR/oe-core/meta/files/common-licenses/GPL-2.0'
ERROR: QA Issue: ostree-kernel-initramfs: LIC_FILES_CHKSUM points to an invalid file: TOPDIR/oe-core/meta/files/common-licenses/GPL-2.0 [license-checksum] ERROR: Fatal QA errors found, failing task.
unfortunately this would be first meta-updater commit which isn't backwards compatible with gatesgarth (for which there isn't separate branch). So either gatesgarth branch should be created before this or maybe we should discuss if this LICENSE value is actually correct (e.g. MIT license files weren't renamed) and this recipe doesn't have own source, the initramfs itself should be covered by the recipe which provides whatever is set in INITRAMFS_IMAGE and kernel from virtual/kernel, but ostree-kernel-initramfs recipe is only metadata, so it might make sense to use MIT (as COPYING.MIT in the root of the repo) or MPL-2 like other metadata-only recipes in this layer (is it intentionally MPL-2 instead of more common for metadata MIT?):
recipes-connectivity/networkd-dhcp-conf/networkd-dhcp-conf.bb:LIC_FILES_CHKSUM = "file://${COMMON_LICENSE_DIR}/MPL-2.0;md5=815ca599c9df247a0c7f619bab123dad" recipes-sota/aktualizr/aktualizr-collectd.bb:LIC_FILES_CHKSUM = "file://${COMMON_LICENSE_DIR}/MPL-2.0;md5=815ca599c9df247a0c7f619bab123dad" recipes-sota/aktualizr/aktualizr-device-prov-hsm.bb:LIC_FILES_CHKSUM = "file://${COMMON_LICENSE_DIR}/MPL-2.0;md5=815ca599c9df247a0c7f619bab123dad" recipes-sota/aktualizr/aktualizr-device-prov.bb:LIC_FILES_CHKSUM = "file://${COMMON_LICENSE_DIR}/MPL-2.0;md5=815ca599c9df247a0c7f619bab123dad" recipes-sota/aktualizr/aktualizr-hwid.bb:LIC_FILES_CHKSUM = "file://${COMMON_LICENSE_DIR}/MPL-2.0;md5=815ca599c9df247a0c7f619bab123dad" recipes-sota/aktualizr/aktualizr-shared-prov-creds.bb:LIC_FILES_CHKSUM = "file://${COMMON_LICENSE_DIR}/MPL-2.0;md5=815ca599c9df247a0c7f619bab123dad" recipes-sota/aktualizr/aktualizr-shared-prov.bb:LIC_FILES_CHKSUM = "file://${COMMON_LICENSE_DIR}/MPL-2.0;md5=815ca599c9df247a0c7f619bab123dad" recipes-sota/aktualizr/aktualizr-uboot-env-rollback.bb:LIC_FILES_CHKSUM = "file://${COMMON_LICENSE_DIR}/MPL-2.0;md5=815ca599c9df247a0c7f619bab123dad" recipes-sota/config/aktualizr-auto-reboot.bb:LIC_FILES_CHKSUM = "file://${COMMON_LICENSE_DIR}/MPL-2.0;md5=815ca599c9df247a0c7f619bab123dad" recipes-sota/config/aktualizr-binary-pacman.bb:LIC_FILES_CHKSUM = "file://${COMMON_LICENSE_DIR}/MPL-2.0;md5=815ca599c9df247a0c7f619bab123dad" recipes-sota/config/aktualizr-disable-send-ip.bb:LIC_FILES_CHKSUM = "file://${COMMON_LICENSE_DIR}/MPL-2.0;md5=815ca599c9df247a0c7f619bab123dad" recipes-sota/config/aktualizr-log-debug.bb:LIC_FILES_CHKSUM = "file://${COMMON_LICENSE_DIR}/MPL-2.0;md5=815ca599c9df247a0c7f619bab123dad" recipes-sota/config/aktualizr-polling-interval.bb:LIC_FILES_CHKSUM = "file://${COMMON_LICENSE_DIR}/MPL-2.0;md5=815ca599c9df247a0c7f619bab123dad" recipes-sota/config/aktualizr-virtualsec.bb:LIC_FILES_CHKSUM = "file://${COMMON_LICENSE_DIR}/MPL-2.0;md5=815ca599c9df247a0c7f619bab123dad" recipes-sota/ostree/ostree-booted_1.0.bb:LIC_FILES_CHKSUM = "file://${COMMON_LICENSE_DIR}/MPL-2.0;md5=815ca599c9df247a0c7f619bab123dad" recipes-support/systemd-journald-persistent/systemd-journald-persistent.bb:LIC_FILES_CHKSUM = "file://${COMMON_LICENSE_DIR}/MPL-2.0;md5=815ca599c9df247a0c7f619bab123dad" recipes-test/demo-config/primary-config.bb:LIC_FILES_CHKSUM = "file://${COMMON_LICENSE_DIR}/MPL-2.0;md5=815ca599c9df247a0c7f619bab123dad" recipes-test/demo-config/secondary-config.bb:LIC_FILES_CHKSUM = "file://${COMMON_LICENSE_DIR}/MPL-2.0;md5=815ca599c9df247a0c7f619bab123dad" recipes-test/demo-network-config/primary-network-config.bb:LIC_FILES_CHKSUM = "file://${COMMON_LICENSE_DIR}/MPL-2.0;md5=815ca599c9df247a0c7f619bab123dad" recipes-test/demo-network-config/secondary-network-config.bb:LIC_FILES_CHKSUM = "file://${COMMON_LICENSE_DIR}/MPL-2.0;md5=815ca599c9df247a0c7f619bab123dad"
Signed-off-by: Martin Jansa Martin.Jansa@gmail.com