Open joeflack4 opened 2 years ago
Hi @joeflack4 - was visiting here because I similarly was attempting to get extra properties out of OWL across into the FHIR.
With regards synonyms however - I could get 'designations' outputted.
"code": "MONDO:0002776",
"display": "external ear disorder",
"designation": [ {
"use": {
"system": "http://snomed.info/sct",
"code": "900000000000013009",
"display": "Synonym (core metadata concept)"
},
"value": "preauricular cyst"
}, {
"use": {
"system": "http://snomed.info/sct",
"code": "900000000000013009",
"display": "Synonym (core metadata concept)"
},
"value": "preauricular sinus or fistula NOS (disorder)"
}, {
"use": {
"system": "http://snomed.info/sct",
"code": "900000000000013009",
"display": "Synonym (core metadata concept)"
},
"value": "preauricular sinus or fistula"
}, {
"use": {
"system": "http://snomed.info/sct",
"code": "900000000000013009",
"display": "Synonym (core metadata concept)"
},
"value": "disease of external ear"
}, {
"use": {
"system": "http://snomed.info/sct",
"code": "900000000000013009",
"display": "Synonym (core metadata concept)"
},
"value": "external ear disease or disorder"
}, {
I think possibly your 'comma splitting' syntax for the invoke is incorrect? I always assumed it meant to split the uris by comma within the shell quotes
e.g.
java -jar fhir-owl-v1.1.jar -i mondo.owl -o mondo.json \
-id mondo \
-name "Mondo" \
-content complete \
-mainNs 'http://purl.obolibrary.org/obo/MONDO_' \
-s 'http://www.geneontology.org/formats/oboInOwl#hasExactSynonym,http://www.geneontology.org/formats/oboInOwl#hasRelatedSynonym' \
-dateRegex "(?<year>\\d{4})-(?<month>\\d{2})-(?<day>\\d{2})" \
-status active \
-codeReplace '_,:'
@andrewpatto Thanks for the suggestion! I'm guessing you are on the money. I'll give this a go and if it works I'll close this issue.
@andrewpatto 's suggestion also works for me - does it meet your requirements @joeflack4 ?
Hey @lawley the syntax of the -s
flag is fine. As for my experience with it, I did just use @andrewpatto's suggestion regarding how to use the arg in a syntactically correct way, and exactSynonym
s do appear as I expect (in designation
)!
Remaining issues:
hasRelatedSynonym
in my example in my original post of the issue).-s
flag, or in the examples, if we could show that the correct syntax is -s "<synonym_uri1>,<synonym_uri2>"
rather thatn -s "<synonym_uri1>","synonym_uri2>"
, I'd like that.Here's the result after my recent conversion using aehrc/fhir-owl
:
{
"code": "MONDO_0002776",
"display": "external ear disorder",
"designation": [ {
"use": {
"system": "http://snomed.info/sct",
"code": "900000000000013009",
"display": "Synonym (core metadata concept)"
},
"value": "preauricular cyst"
}, {
"use": {
"system": "http://snomed.info/sct",
"code": "900000000000013009",
"display": "Synonym (core metadata concept)"
},
"value": "preauricular sinus or fistula NOS (disorder)"
}, {
"use": {
"system": "http://snomed.info/sct",
"code": "900000000000013009",
"display": "Synonym (core metadata concept)"
},
"value": "preauricular sinus or fistula"
}, {
"use": {
"system": "http://snomed.info/sct",
"code": "900000000000013009",
"display": "Synonym (core metadata concept)"
},
"value": "disease of external ear"
}, {
"use": {
"system": "http://snomed.info/sct",
"code": "900000000000013009",
"display": "Synonym (core metadata concept)"
},
"value": "external ear disease or disorder"
}, {
"use": {
"system": "http://snomed.info/sct",
"code": "900000000000013009",
"display": "Synonym (core metadata concept)"
},
"value": "preauricular cyst (disorder)"
}, {
"use": {
"system": "http://snomed.info/sct",
"code": "900000000000013009",
"display": "Synonym (core metadata concept)"
},
"value": "external ear disease"
}, {
"use": {
"system": "http://snomed.info/sct",
"code": "900000000000013009",
"display": "Synonym (core metadata concept)"
},
"value": "preauricular sinus and fistula (disorder)"
}, {
"use": {
"system": "http://snomed.info/sct",
"code": "900000000000013009",
"display": "Synonym (core metadata concept)"
},
"value": "disorder of external ear"
}, {
"use": {
"system": "http://snomed.info/sct",
"code": "900000000000013009",
"display": "Synonym (core metadata concept)"
},
"value": "preauricular sinus and fistula"
}, {
"use": {
"system": "http://snomed.info/sct",
"code": "900000000000013009",
"display": "Synonym (core metadata concept)"
},
"value": "disease or disorder of external ear"
} ],
"property": [ {
"code": "imported",
"valueBoolean": false
}, {
"code": "parent",
"valueCode": "MONDO_0021205"
}, {
"code": "parent",
"valueCode": "MONDO_0002409"
}, {
"code": "root",
"valueBoolean": false
}, {
"code": "deprecated",
"valueBoolean": false
} ]
}
For comparison, here's the tentative output for this in the current version of my tool:
{
"code": "0002776",
"property": [
{
"code": "hasExactSynonym",
"valueCoding": {
"system": "NCIT",
"code": "C26972",
"display": "external ear disorder"
}
},
{
"code": "hasExactSynonym",
"valueCoding": {
"system": "MONDO",
"code": "design_pattern",
"display": "external ear disease or disorder"
}
},
{
"code": "hasExactSynonym",
"valueCoding": {
"system": "MONDO",
"code": "patterns/location",
"display": "external ear disease or disorder"
}
},
{
"code": "hasRelatedSynonym",
"valueCoding": {
"system": "DOID",
"code": "379",
"display": "preauricular cyst"
}
},
{
"code": "hasRelatedSynonym",
"valueCoding": {
"system": "DOID",
"code": "379",
"display": "preauricular sinus or fistula NOS (disorder)"
}
},
{
"code": "hasExactSynonym",
"valueCoding": {
"system": "MONDO",
"code": "patterns/location_top",
"display": "disorder of external ear"
}
},
{
"code": "hasRelatedSynonym",
"valueCoding": {
"system": "DOID",
"code": "379",
"display": "preauricular cyst (disorder)"
}
},
{
"code": "hasRelatedSynonym",
"valueCoding": {
"system": "DOID",
"code": "379",
"display": "preauricular sinus or fistula"
}
},
{
"code": "hasExactSynonym",
"valueCoding": {
"system": "MONDO",
"code": "patterns/location_top",
"display": "disease of external ear"
}
},
{
"code": "hasExactSynonym",
"valueCoding": {
"system": "MONDO",
"code": "patterns/location",
"display": "external ear disease"
}
},
{
"code": "hasRelatedSynonym",
"valueCoding": {
"system": "DOID",
"code": "379",
"display": "preauricular sinus and fistula (disorder)"
}
},
{
"code": "hasExactSynonym",
"valueCoding": {
"system": "DOID",
"code": "379",
"display": "preauricular sinus and fistula"
}
},
{
"code": "parent",
"valueCode": "http://purl.obolibrary.org/obo/UBERON_0001691"
},
{
"code": "parent",
"valueCode": "0002776"
},
{
"code": "parent",
"valueCode": "0002776"
}
],
"display": "external ear disorder",
"definition": "A disease involving the external ear.",
"designation": [
{
"use": {
"system": "NCIT",
"code": "C26972",
"display": "Synonym (core metadata concept)"
},
"value": "external ear disorder"
},
{
"use": {
"system": "MONDO",
"code": "design_pattern",
"display": "Synonym (core metadata concept)"
},
"value": "external ear disease or disorder"
},
{
"use": {
"system": "MONDO",
"code": "patterns/location",
"display": "Synonym (core metadata concept)"
},
"value": "external ear disease or disorder"
},
{
"use": {
"system": "MONDO",
"code": "patterns/location_top",
"display": "Synonym (core metadata concept)"
},
"value": "disorder of external ear"
},
{
"use": {
"system": "MONDO",
"code": "patterns/location_top",
"display": "Synonym (core metadata concept)"
},
"value": "disease of external ear"
},
{
"use": {
"system": "MONDO",
"code": "patterns/location",
"display": "Synonym (core metadata concept)"
},
"value": "external ear disease"
},
{
"use": {
"system": "DOID",
"code": "379",
"display": "Synonym (core metadata concept)"
},
"value": "preauricular sinus and fistula"
}
]
},
Overview
I'm trying to convert Mondo from OWL to FHIR. However, synonyms are not appearing.
Example current output
Example expected output
I expect something like this. Leaving out irrelevant properties and only including 1 of the 11 synonyms here:
Reproducing
fhir-owl
with the synonym flag-s
:Additional info
Examples of synonym usage in `mondo.owl
Terminal output
It appears to say that it is loading the synonyms (near the bottom). I see messages about some mappings found, but none of them appear to be related to the synonyms namespace I am using,
http://www.geneontology.org/formats/oboInOwl#
.