Open nielmdrec opened 7 months ago
AFAIK, the $expand operation typically only looks at Valueset.expansion as the expansion result. Ideally, the ordinalValue extension should be included in Valueset.expansion, not the other way around (renderer looking in ValueSet.compose.include).
There is some discussion here on Zulip: https://chat.fhir.org/#narrow/stream/179202-terminology/topic/ordinalValue.20extension https://chat.fhir.org/#narrow/stream/179202-terminology/topic/.24expand.20with.20extensions
I'm still not sure what's the best workaround for this, perhaps we can do as you suggested at the moment. But I might wait for a bit more updates from Brian before proceeding.
Please let me know if it's a blocker.
Thanks, Sean. This is not a blocker for us. As you mentioned, there is a workaround for this.
From: Sean Fong @.> Date: Wednesday, 14 February 2024 at 1:59 pm To: aehrc/smart-forms @.> Cc: Niel Sayo @.>, Author @.> Subject: Re: [aehrc/smart-forms] Ordinal extension not supported in contained Valueset when using compose but works on expansion (Issue #621)
AFAIK, the $expand operation typically only looks at Valueset.expansion as the expansion result. Ideally, the ordinalValue extension should be included in Valueset.expansion, not the other way around (renderer looking in ValueSet.compose.include).
There is some discussion here on Zulip: https://chat.fhir.org/#narrow/stream/179202-terminology/topic/ordinalValue.20extension https://chat.fhir.org/#narrow/stream/179202-terminology/topic/.24expand.20with.20extensions
I'm still not sure what's the best workaround for this, perhaps we can do as you suggested at the moment. But I might wait for a bit more updates from Brian before proceeding.
Please let me know if it's a blocker.
— Reply to this email directly, view it on GitHubhttps://github.com/aehrc/smart-forms/issues/621#issuecomment-1943011431, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AQ2YQPRQSJHZEPC6DEEJ3S3YTQSAHAVCNFSM6AAAAABC5BUVQ2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNBTGAYTCNBTGE. You are receiving this because you authored the thread.Message ID: @.***>
If the Questionnaire contains a Valueset that uses the ordinal extension within an expansion, then the SMART forms renderer is able to display it without issues.
However, if the same extension is used within a compose, the valueset causes this error:
Details: