search

aembke / redis-protocol.rs

A Rust implementation of RESP2 and RESP3
Apache License 2.0
39 stars 13 forks source link

Fix failing tests #12

Closed rukai closed 2 years ago

rukai commented 3 years ago

These unittests were failing on my machine but not on CI. The order of sets and hashmaps is not guaranteed so we have to take that into account when we make assertions.

If adding itertools as a dev-dependency is undesirable I can investigate other ways of getting permutations.

rukai commented 3 years ago

Oh I just realized the reason that CI is passing is because it runs cargo test --release --features index-map. I still think this PR is useful as we should be testing the default functionality as well and it makes it easier for developers to successfully run the tests locally. I'll update the PR to also run cargo test --release in CI.

aembke commented 2 years ago

Closing after merging https://github.com/aembke/redis-protocol.rs/pull/14.