aemsites / danaher-abcam

Apache License 2.0
0 stars 0 forks source link

PDP Popup: Recommended Products and Recently Viewed - Tab and Quick View #10

Closed Meenu-GSPANN closed 2 weeks ago

Meenu-GSPANN commented 1 month ago

Recommended Products: Full product info, Tab Functionality(Quick View, Publication, Review-almost similar to Overview) Recently Viewed: almost similar to recommended products

Rajesh-GSPANN commented 1 month ago

Hi , Started Working on the issue. Looking PDP API call to reuse the response.

CC: @Meenu-GSPANN

Rajesh-GSPANN commented 1 month ago

Hi @davidzochowski ,

While fetching the details of the Product Detail Page (PDP), we are receiving the following fields: 'images', 'publicationsjson', and other fields. To filter the images or publications based on the selected 'Application' and 'Species' filters, we need to have a mapping of the fields. Could you please provide the necessary information to enable filtering based on these criteria?

Additionally, we need to know which fields to use to display the Reviews and Ratings, as well as the mappings required to filter the Reviews upon selecting the 'Application' and 'Species' filters. Please let us know we can schedule a call to discuss more on this.

CC: @Meenu-GSPANN @rgravitvl @sharanagoudapatil @amlan18041996 @venkateshamkeerthi

Rajesh-GSPANN commented 1 month ago

Hi , I have started implementing the functionality with the basic available data, Like product code , title.

@davidzochowski , did you get a chance to look into the above comment (August 12th).

CC: @Meenu-GSPANN @davenichols-DHLS @rgravitvl @amlan18041996 @shivangi1422

davidzochowski commented 1 month ago

Hi Rajesh,

I have added the reactivity and species fields as part of the publicationsjson object. The imagesjson object already has those fields so you should be able to build that section immediately.

I have started a rebuild. You should start seeing the data come through over time.

One thing to note, to fix an issue where the json list fields were nonparseable, I have made publicationsjson and imagesjson into a single string field. You will need to do a slight modification with how you are reading the fields.

Rajesh-GSPANN commented 1 month ago

Thanks for the update @davidzochowski , How about the reviews and ratings part ?

CC: @Meenu-GSPANN @davenichols-DHLS @rgravitvl @amlan18041996 @pardeepgera23 @venkateshamkeerthi

Rajesh-GSPANN commented 1 month ago

Hi @davidzochowski , During our discussion, we determined that the Reviews and Ratings are fetched from a separate endpoint, which presents challenges in integrating the data into our system. As a result, we have decided to temporarily set aside the Reviews and Ratings section and will revisit it once we have the necessary details. Now, we will proceed with implementing the Overview section and the Publication section.

CC: @davenichols-DHLS @rgravitvl @Meenu-GSPANN @pardeepgera23 @amlan18041996 @venkateshamkeerthi @Naveen-Ramgiri

Rajesh-GSPANN commented 1 month ago

Hi @davidzochowski ,

I had a look into imagesJson object (product I used for analysis AB1791) and found that 1.Reactive species are not available for applications

  1. There are two image URLs we have 'url' and 'seoUrl' and these URLs are relative, we don't have complete path to the image. and which one to use. Can you please have a look into this .

CC: @davenichols-DHLS @rgravitvl @Meenu-GSPANN @pardeepgera23 @amlan18041996 @venkateshamkeerthi @Naveen-Ramgiri @shivangi1422

Thanks!

davidzochowski commented 1 month ago

HI Rajesh,

  1. Not sure what you mean by this. Looking at the abcam page, images has only one filter and that is for application. This is present within the imagesjson.
  2. Use the seoURL and prepend with https://content.abcam.com Ex. https://content.abcam.com/products/images/histone-h3-antibody-nuclear-marker-and-chip-grade-ab1791--chip-img110703.jpg
Rajesh-GSPANN commented 1 month ago

Hi @davidzochowski ,

  1. If we look at the Bottom right of the images , we see reactive Species, Even there are filtering on the Application filter. Attached screenshots for reference.
  2. Sure, I will use seoURL.

All Application Filter on application

CC: @davenichols-DHLS @rgravitvl @Meenu-GSPANN @pardeepgera23 @amlan18041996 @venkateshamkeerthi @Naveen-Ramgiri @shivangi1422

Thanks!

Rajesh-GSPANN commented 1 month ago

Hi , Implemented Bottom Section of the Overview section. Working on the responsive.

image

CC: @davidzochowski @davenichols-DHLS @Meenu-GSPANN @amlan18041996 @pardeepgera23 @venkateshamkeerthi @Naveen-Ramgiri

Rajesh-GSPANN commented 4 weeks ago

Hi, Able to show the image carousel. And filter them by application. Working on the slide part. image

CC: @Meenu-GSPANN @pardeepgera23 @amlan18041996 @shivangi1422

Rajesh-GSPANN commented 3 weeks ago

Hi @davidzochowski , Did you get a chance to look into my query? that I have asked few days back (on August -16th). Can you please have a look into this and let us know.

CC: @davenichols-DHLS @Meenu-GSPANN @pardeepgera23 @venkateshamkeerthi @amlan18041996

davidzochowski commented 3 weeks ago

@Rajesh-GSPANN The Images json has both an 'application' and 'species' field defined for each image.

Screenshot 2024-08-28 at 12 27 29 PM
Rajesh-GSPANN commented 3 weeks ago

Noted @davidzochowski . Thanks!

Hi, Implemented the functionality and desktop design completed. image

CC: @davenichols-DHLS @Meenu-GSPANN @pardeepgera23 @rgravitvl @shivangi1422

Rajesh-GSPANN commented 2 weeks ago

Hi, PR yet to be raised, waiting for other PRs to be merged.

CC: @davenichols-DHLS @Meenu-GSPANN @pardeepgera23 @amlan18041996

Rajesh-GSPANN commented 2 weeks ago

Hi @rgravitvl, @pardeepgera23 Can you please review the PR CC: @Meenu-GSPANN @amlan18041996 @shivangi1422

Rajesh-GSPANN commented 2 weeks ago

Hi, PR is merged into Optimus repo, hence closing the ticket.

CC : @rgravitvl @pardeepgera23 @Meenu-GSPANN

Thanks!