search

aemsites / icicidirect

Apache License 2.0
0 stars 1 forks source link

Finace block #57

Closed sdmcraft closed 4 months ago

sdmcraft commented 4 months ago
image

A dynamic block to pull data from api and show up cards in a carousel. The individual items in the carousel are cards.

anagarwa commented 4 months ago

@shrotia have you started on this one ?

shrotia commented 4 months ago

@shrotia have you started on this one ?

Yes, I tried using the existing Carousel, but it seems it's very specific for 'oneclickportfolio', 'trading', and 'investing'. I'm figuring out how to make it generic for other Carousels we have on the page.

anagarwa commented 4 months ago

@shrotia if it comes too much effort to make it generic, we can look at making a different variant of carousel since there are multiple carousel (like videos and podcast)and making a generic carousel might become too tricky.

shrotia commented 4 months ago

Because all the carousels look the same, I believe we should have just one carousel for various experiences.

we can look at making a different variant of carousel since

I'm working on a FinAce specific experience that will consume this: https://main--aem-block-collection--adobe.hlx.live/block-collection/carousel