search

aemsites / stericycle-shared

Edge Delivery Service Site for Stericycle sites
https://www.shredit.com, https://www.stericycle.com
Apache License 2.0
0 stars 0 forks source link

Header - Find Your Service Center Issue #160

Closed colinvlasak closed 3 days ago

colinvlasak commented 1 month ago

Find Your Service Center doesn’t work in the header. When you click the link nothing happens. Should open a popout menu with the ability to enter location details.

Should look like this: image

colinvlasak commented 3 days ago

@bstopp there are still a few issues here

  1. When you enter a zip code or state it just takes you to the https://main--shredit--stericycle.aem.live/en-us/service-locations page with no filtering on the map. It should load the page with the map filtered based on the search. So if you search a zip it should only show the branches on the map near that zip.

  2. If you try to use the Find Your Service Center function while on the service locations page it causes a bug. Button turns white and it doesn't do anything.

image

  1. The Service Locations link at the bottom of the popout links to the wrong page. Goes to https://main--shredit--stericycle.aem.live/en-us/locations should go to https://main--shredit--stericycle.aem.live/en-us/service-locations

image

  1. When you click on the Find Your Service Center option the autofill comes up before you click in the search field which covers up the Service Locations link. Can we make it so it only appears once a user clicks in.

image

bstopp commented 3 days ago

I captured 1 in issue #407 - As this is a bug in the Service Location block, not the header.

I don't experience issue 2 or 4.

I have opened PR #408 to address 3.

colinvlasak commented 3 days ago

@bstopp 2 and 4 are happening on my end and need to be resolved.

For #2

4

Looks to be specific to Google Chrome. You will have had to have searched previous terms on the site for this to happen.

bstopp commented 3 days ago

Ok - I think i got 2 & 4 fixed. With PR #408 as well

colinvlasak commented 3 days ago

@bstopp looks like 2,3, and 4 are fixed through #408 - on https://bug-service-location-url--shredit--stericycle.aem.page/en-us. Can we push them up to live?

Will look out for updates in #407 re: 1

bstopp commented 3 days ago

Pushed to live.