search

aemsites / stericycle-shared

Edge Delivery Service Site for Stericycle sites
https://www.shredit.com, https://www.stericycle.com
Apache License 2.0
0 stars 1 forks source link

adds search capabilities #433

Closed MarquiseRosier closed 3 weeks ago

MarquiseRosier commented 3 weeks ago

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Fix #432

Test URLs:

aem-code-sync[bot] commented 3 weeks ago

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed. In case there are problems, just click a checkbox below to rerun the respective action.

Commits * [9a62aa9](https://github.com/aemsites/stericycle-shared/commit/9a62aa923ba547e18a96c6ed0456966cdbfa0b7a) :white_check_mark: (latest) * [d699465](https://github.com/aemsites/stericycle-shared/commit/d69946508e68d568db9ca04e4bbeab54129adee8) :white_check_mark: * [8e28517](https://github.com/aemsites/stericycle-shared/commit/8e285171dbc0501241df7975a1f6c417195b8951) :white_check_mark: * [9ed2978](https://github.com/aemsites/stericycle-shared/commit/9ed2978b3f510781dc30eff74b4534facde6942e) :white_check_mark: * [191ce58](https://github.com/aemsites/stericycle-shared/commit/191ce5827a24143ca81949c0ae2343cea5ad32a7) :white_check_mark: * [cf466de](https://github.com/aemsites/stericycle-shared/commit/cf466dec025690666cb2c3f38ce08a2355ba32db) :white_check_mark: * [9ea83c4](https://github.com/aemsites/stericycle-shared/commit/9ea83c4c037d0ac520432858d0fe36bf4ca0817a) :white_check_mark: * [58ae4be](https://github.com/aemsites/stericycle-shared/commit/58ae4be85d265b44db30d323fad4259736aa7104) :white_check_mark: * [efe9dd2](https://github.com/aemsites/stericycle-shared/commit/efe9dd2be2d466473d2f730abf7a25c9cd12b1c9) :white_check_mark: * [76a0a59](https://github.com/aemsites/stericycle-shared/commit/76a0a59d99328e9c98be7a11cf3da97de4ee757e) :white_check_mark: * [8117820](https://github.com/aemsites/stericycle-shared/commit/8117820924abdafc8dcbdd281d9c2c18d3ce93c8) :white_check_mark: * [e3c15a9](https://github.com/aemsites/stericycle-shared/commit/e3c15a9d12de48c515c0c1b41be8eb9bb188594d) :white_check_mark: * [02ee950](https://github.com/aemsites/stericycle-shared/commit/02ee950b6d8defd967b08f061fe91bc92ca876d1) :white_check_mark: * [cccd0d1](https://github.com/aemsites/stericycle-shared/commit/cccd0d15161192f760c292f03ad1c150e2089443) :white_check_mark: * [8f480d6](https://github.com/aemsites/stericycle-shared/commit/8f480d6fc47557244b698683d13c5be8eb738720) :white_check_mark:
aem-code-sync[bot] commented 3 weeks ago
Page Scores Audits Google
:iphone: /en-us/search PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
:desktop_computer: /en-us/search PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
kronnox commented 3 weeks ago

Is there any reason you don't use our version of ffetch that already has the local storage caching and stuff in place?

MarquiseRosier commented 3 weeks ago

@bstopp that

If not running the search (i.e. term is too short "te"), then something should be displayed, even if it's "not enough input"

Live site actually just shows "No results" message.

@bstopp that should be resolved now!