search

aergoio / litetree

SQLite with Branches
MIT License
1.62k stars 35 forks source link

Use variables instead of hard-coded paths in makefile #11

Closed k-lukas closed 6 years ago

kroggen commented 6 years ago

Hi Lukas,

Thank you for your contribution!

Pull requests should be based on the develop branch. Could you do it there?

The changes are not passing on Windows. We could update the AppVeyor script to use INCPATH instead of LMDBPATH but I noticed that on Linux and Mac this last variable points to where the LMDB library is located, not the header files.

We need 2 different variables, one to point where the LMDB library is installed and another to point to where the LMDB header files are located. So they can be LMDBPATH and LMDBINCPATH.

On Windows these files are generally on the same folder, so we can pass just LMDBPATH (as already being done in appveyor).

Additional changes on makefile:

on Windows section:

LMDBPATH = ../lmdb/lib...
LMDBINCPATH = $(LMDBPATH)

on Linux and Mac common section:

LMDBINCPATH = /usr/local/include
LMDBPATH = /usr/local/lib
k-lukas commented 6 years ago

I'll create new PR and close this one because I can't change the source branch.