search

aerogear / aerogear-android-sdk

AeroGear Services Android SDK
Apache License 2.0
8 stars 31 forks source link

Decouple service creation from MobileCore #269

Closed danielpassos closed 6 years ago

danielpassos commented 6 years ago

Related issues:

wtrocki commented 6 years ago

Nice to see this done as the change is going to unify how the SDK is being build. Currently push service etc. is standalone class while Auth itself is basing on the service interface. I have tested auth with showcase with this changes. I haven't been working a lot with the Android core so leaving approval for code owners.

secondsun commented 6 years ago

LGTM, I trust @wtrocki when he says it works.

danielpassos commented 6 years ago

@wei-lee Wanna take a look before the merge?

wtrocki commented 6 years ago

It's worth to add that this change unifies entire SDK to use one common aproach and make it aligned with how other SDK's are build. Without this change on master we will have 3 different API variations available which could be confusing for end users.

@danielpassos My guess that this was your motivation to do it ;)