search

aerogear / offix-android

Apollo GraphQL offline extensions for Android Platform
https://android.offix.dev
Apache License 2.0
37 stars 16 forks source link

Simplify the sample app #106

Closed harshithdwivedi closed 5 years ago

harshithdwivedi commented 5 years ago

Let's keep the sample app as simple as possible. Currently, it's overloaded with things that the developer doesn't need to know; for example, MVVM Architecture, ViewModels, etc.

Let's get rid of them and have a basic android app with as few java/kotlin files as possible.

Lavanyagaur22 commented 5 years ago

Yeah, the users would get a better understanding of the library then.

wtrocki commented 5 years ago

Agreed. We landed server so we might also integrate with new server side and give developers nice end to end example

harshithdwivedi commented 5 years ago

Created #107

wtrocki commented 5 years ago

Love it! I actually went quickly into sample app and it is really huge in terms of code that is not offix related, so our initial proposal to use patterns for implementation do not work nicely. making it simple should not require a lots of work anyway and extended schema can give us much more freedom.

Ping me if you get any questions about server schema.

harshithdwivedi commented 5 years ago

This is completed