Closed rlouf closed 1 year ago
Attention: Patch coverage is 86.66667%
with 4 lines
in your changes missing coverage. Please review.
Project coverage is 98.03%. Comparing base (
64b0e50
) to head (fd670d5
). Report is 19 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
aemcmc/utils.py | 80.00% | 1 Missing and 3 partials :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Decisions regarding the output format will be informed by the constraints that a general-purpose sampling function imposes.
Here are some thoughts:
- Returning a dictionary indexed by variable name requires users to name variables. How do we handle missing names?
We could automatically generate sequential names.
Alternatively, we return a list and provide another function(s) that generate other formats, dict
, xarray
We could automatically generate sequential names.
Definitely; and we can use the Variable.auto_name
values for that.
Alternatively, we return a list and provide another function(s) that generate other formats,
dict
,xarray
Also a very viable approach!
Here we add a utility function to generate prior samples for any variable present in a model. The function should return samples in a format that is convenient for the users. The format is still TBD, although the standard in the Python PPL world seems to be XArray (for compatibility with ArviZ).
Note: it is not necessary to pass the updates to
function
in this case (but we need to make sure to return them as outputs to Scan's inner function), can we just not return them at all to simplify the interface further?Related to #101