aewallin / allantools

Allan deviation and related time & frequency statistics library in Python
GNU Lesser General Public License v3.0
222 stars 76 forks source link

psd2allan and improvements of noise functions #110

Closed EBenkler closed 5 years ago

EBenkler commented 5 years ago
  1. This pull request introduces a function to convert a given spectral density S_y to ADEV or modADEV.
  2. There is also a test script, but I am not sure if it is correctly implemented into the pytest workflow. Please check this and let me know how it can be improved.
  3. Since the test requires the generation of noise, I also modified the allantools.noise.violet() noise generation function and applied some cosmetics to some of the other noise functions to achieve consistent nomenclature of noise level coefficients.
pep8speaks commented 5 years ago

Hello @EBenkler! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 1382:1: E302 expected 2 blank lines, found 1 Line 1382:32: E251 unexpected spaces around keyword / parameter equals Line 1429:80: E501 line too long (80 > 79 characters) Line 1432:38: E261 at least two spaces before inline comment Line 1433:15: E225 missing whitespace around operator Line 1434:29: E261 at least two spaces before inline comment Line 1434:80: E501 line too long (88 > 79 characters) Line 1435:15: E225 missing whitespace around operator Line 1439:37: E261 at least two spaces before inline comment Line 1440:23: E225 missing whitespace around operator Line 1441:8: E225 missing whitespace around operator Line 1442:7: E225 missing whitespace around operator Line 1443:6: E225 missing whitespace around operator Line 1443:33: E225 missing whitespace around operator Line 1444:8: E225 missing whitespace around operator Line 1445:6: E225 missing whitespace around operator Line 1447:9: E225 missing whitespace around operator Line 1447:21: E261 at least two spaces before inline comment Line 1448:6: E225 missing whitespace around operator Line 1450:80: E501 line too long (96 > 79 characters) Line 1453:14: E225 missing whitespace around operator Line 1460:17: E225 missing whitespace around operator Line 1461:33: E261 at least two spaces before inline comment Line 1462:17: E225 missing whitespace around operator Line 1464:14: E225 missing whitespace around operator Line 1465:11: E128 continuation line under-indented for visual indent Line 1466:11: E128 continuation line under-indented for visual indent Line 1468:14: E225 missing whitespace around operator Line 1469:6: E225 missing whitespace around operator Line 1470:23: E225 missing whitespace around operator

Line 110:80: E501 line too long (80 > 79 characters) Line 134:80: E501 line too long (85 > 79 characters) Line 156:80: E501 line too long (80 > 79 characters) Line 205:30: W292 no newline at end of file

Line 6:1: E402 module level import not at top of file Line 7:1: E402 module level import not at top of file Line 8:1: E402 module level import not at top of file Line 9:22: E261 at least two spaces before inline comment Line 10:1: E402 module level import not at top of file Line 12:1: E402 module level import not at top of file Line 13:1: E402 module level import not at top of file Line 13:5: E271 multiple spaces after keyword Line 15:1: E302 expected 2 blank lines, found 1 Line 16:6: E225 missing whitespace around operator Line 16:24: E261 at least two spaces before inline comment Line 16:80: E501 line too long (94 > 79 characters) Line 17:9: E225 missing whitespace around operator Line 17:15: E261 at least two spaces before inline comment Line 18:12: E225 missing whitespace around operator Line 18:38: E261 at least two spaces before inline comment Line 19:12: E225 missing whitespace around operator Line 19:26: E261 at least two spaces before inline comment Line 25:19: E225 missing whitespace around operator Line 25:22: E231 missing whitespace after ',' Line 25:32: E225 missing whitespace around operator Line 26:19: E225 missing whitespace around operator Line 26:22: E231 missing whitespace after ',' Line 26:32: E225 missing whitespace around operator Line 28:14: E225 missing whitespace around operator Line 28:39: E251 unexpected spaces around keyword / parameter equals Line 29:14: E225 missing whitespace around operator Line 29:40: E251 unexpected spaces around keyword / parameter equals Line 30:19: E225 missing whitespace around operator Line 30:36: E231 missing whitespace after ',' Line 30:80: E501 line too long (85 > 79 characters) Line 31:19: E225 missing whitespace around operator Line 31:36: E231 missing whitespace after ',' Line 31:80: E501 line too long (85 > 79 characters) Line 33:17: E231 missing whitespace after ',' Line 34:17: E231 missing whitespace after ',' Line 39:5: E265 block comment should start with '# ' Line 40:5: E265 block comment should start with '# ' Line 41:5: E265 block comment should start with '# ' Line 42:5: E265 block comment should start with '# ' Line 43:21: E225 missing whitespace around operator Line 43:50: E251 unexpected spaces around keyword / parameter equals Line 44:21: E225 missing whitespace around operator Line 44:50: E251 unexpected spaces around keyword / parameter equals Line 45:24: E225 missing whitespace around operator Line 45:53: E251 unexpected spaces around keyword / parameter equals Line 46:24: E225 missing whitespace around operator Line 46:53: E251 unexpected spaces around keyword / parameter equals Line 54:25: E225 missing whitespace around operator Line 54:58: E251 unexpected spaces around keyword / parameter equals Line 55:25: E225 missing whitespace around operator Line 55:58: E251 unexpected spaces around keyword / parameter equals Line 56:28: E225 missing whitespace around operator Line 56:61: E251 unexpected spaces around keyword / parameter equals Line 57:28: E225 missing whitespace around operator Line 57:61: E251 unexpected spaces around keyword / parameter equals Line 64:8: E225 missing whitespace around operator Line 65:19: E225 missing whitespace around operator Line 66:19: E225 missing whitespace around operator Line 67:22: E225 missing whitespace around operator Line 68:22: E225 missing whitespace around operator Line 77:80: E501 line too long (83 > 79 characters) Line 78:80: E501 line too long (82 > 79 characters) Line 79:80: E501 line too long (89 > 79 characters) Line 84:80: E501 line too long (81 > 79 characters) Line 88:1: E305 expected 2 blank lines after class or function definition, found 1 Line 88:12: E225 missing whitespace around operator

Comment last updated at 2019-09-23 06:19:40 UTC
coveralls commented 5 years ago

Coverage Status

Coverage increased (+0.2%) to 81.336% when pulling 2391ccd105dad1b44b84528e5f589ccc35e2556c on EBenkler:master into b34921d86f5e4bede30043373925a68fc6037f63 on aewallin:master.