search

aex351 / home-assistant-neerslag-app

Neerslag app for Home Assistant. All-in-one package (Sensors + Card).
62 stars 18 forks source link

Feat : fr translation #29

Closed alexbelgium closed 2 years ago

alexbelgium commented 2 years ago

Hello,

I've re-created the french translation (and english translation fix) PR while using Github online which should ensure to keep current formatting

alexbelgium commented 2 years ago

Shouldn't it be in english by default, and nl only for people who have set their HA this way ?

alexbelgium commented 2 years ago

I've noticed that last line of the js was modified although I didn't touch it. It looks like github automatically adds a newline at end of the file. Not sure how to avoid that.

It is all the more strange that if you look in the files changes of my commits, this update doesn't appear.

aex351 commented 2 years ago

Thanks for your contribution.

The pull request focuses on adding French language. It also contains a small fix for the English language and with that fix the last line, that contains an external Javascript library also has been reported as being changed. I can't verify this has been untouched. For that reason I can't approve this pull request.

My proposed solution. Keep this pull request focused on the French language (because that's the main goal) and remove dd7cb7f. Also that fix belongs to the 'Neerslag Card' (which is in a separate repository). You can make another pull request for that or I will fix it myself in the upcoming update.

alexbelgium commented 2 years ago

Also that fix belongs to the 'Neerslag Card' (which is in a separate repository). You can make another pull request for that or I will fix it myself in the upcoming update.

Well I have also created a PR on the card repo for the French translation. However I see that there is the same issue of modifying the javascript library.

I'll try a last time then will drop the PR if that doesn't work.

aex351 commented 2 years ago

I have cherry picked the main feature of this pull request. The other commits I will include in the 'Neerslag Card' repository.