search

aferrero2707 / PhotoFlow

A fully non-destructive photo retouching program providing a complete layer-based workflow including RAW image development.
http://aferrero2707.github.io/PhotoFlow
GNU General Public License v3.0
316 stars 36 forks source link

PF crashes when monitor color profile doesn't exist any more #183

Closed phweyland closed 5 years ago

phweyland commented 5 years ago

After having moved the corresponding folder pf started to crash when open whatever file type. Backtrace: PhotoFlow-05.txt

aferrero2707 commented 5 years ago

Thanks! I must introduce a safe fallback and a warning message in this case... meanwhile, you should be able to fix the situation by manually editing the PhF configuration file and remove the line that contains the missing monitor profile...

The config file under windows can be found in

%LocalAppData%\photoflow\config\options
phweyland commented 5 years ago

Good to know ! I've just redefined the monitor profile in preference before opening an image and that did work.

aferrero2707 commented 5 years ago

Should be fixed by 3795f6976c61edc78a793e39251e375623731a9e The program now pops up an information dialog that warns the user that the display profile cannot be found, and then falls back to sRGB.

Could you please check and confirm before I close the issue?

Thanks!

phweyland commented 5 years ago

Made a try but was unsuccessful. Here is the backtrace: photoflow_bt.txt

aferrero2707 commented 5 years ago

@phweyland I just realized that there was a problem when building the Win64 package, so you likely tested and older version of the code. The win64 package corresponding to the git head is now available: https://github.com/aferrero2707/PhotoFlow/releases/download/continuous/photoflow-w64-20190218_1830-git-stable-5f101bf82b3d506e5acee73ca40a5af186a0151e.zip

Sorry for that!

phweyland commented 5 years ago

Good ! image

aferrero2707 commented 5 years ago

Great! Then I will close this one.

Thanks for the feedback!