search

aferrero2707 / PhotoFlow

A fully non-destructive photo retouching program providing a complete layer-based workflow including RAW image development.
http://aferrero2707.github.io/PhotoFlow
GNU General Public License v3.0
316 stars 36 forks source link

Build fails on i386: result of comparison 'size_t' (aka 'unsigned int') > 4294967295 is always false #192

Open yurivict opened 5 years ago

yurivict commented 5 years ago 
/wrkdirs/usr/ports/graphics/photoflow/work/PhotoFlow-da84a071/src/external/rawspeed/src/librawspeed/io/FileReader.cpp:62:16: error: result of comparison 'size_t' (aka 'unsigned int') > 4294967295 is always false [-Werror,-Wtautological-type-limit-compare]
  if (fileSize > std::numeric_limits<Buffer::size_type>::max())
      ~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.

See the log: http://beefy5.nyi.freebsd.org/data/120i386-default/504051/logs/photoflow-0.2.8.1260_1.log

aferrero2707 commented 5 years ago

Honestly I do not know if RawSpeed is expected to compile correctly on 32 bit architectures... I will ask the developers about this.