search

afids / afids-validator

Validator for the anatomical fiducial placement protocol
https://validator.afids.io
GNU General Public License v3.0
2 stars 4 forks source link

Stop using FLASK_ENV #204

Closed tkkuehn closed 11 months ago

tkkuehn commented 1 year ago

The problem

The FLASK_ENV config variable is deprecated in favour of FLASK_DEBUG (according to startup logs). We need to look into this and refactor the config code accordingly.

kaitj commented 11 months ago

Took a dive into this - we set the FLASK_ENV variable to define the environment we are in, however we use the appropriate DEBUG and TESTING variables for configuration.

While Flask may have changed this, I think for our purposes, making use of a single FLASK_ENV variable is still easiest for a contributor to change between the different environments with the code handling all of the necessary configuration.

The code will be refactored a little bit to make it more concise, but I think this ends up being a non-issue for us. We can revisit this in the future if this is something we want to change.