search

afonsocraposo / ppg

App that measures the PPG using the phone's camera. App built using Flutter, but only tested on Android.
GNU General Public License v3.0
59 stars 36 forks source link

setstate correction #2

Closed im-Amitto closed 4 years ago

im-Amitto commented 4 years ago

Fix #1 This issue was also pointed by a guy in the comment section of your blog@medium. Description: Estimated BP is not updated. Note: (_bpm > 30 && _bpm < 150) condition has been removed while recording the video Before PR: https://www.loom.com/share/1668dc52284246d98cbe9fe3a8b125f6 After PR: https://www.loom.com/share/8ceef11c67954f1983b6558740935691

afonsocraposo commented 4 years ago

The condition: _bpm > 30 && _bpm < 150 Is there to avoid the display of incorrect bpm values, since the normal range of values for a healthy adult is between 60 and 90, and values smaller than 30 or greater than 150 would be very unlikely

im-Amitto commented 4 years ago

@Afonsocraposo This PR is not about the condition. I just took the assumption while recording the video so I can show you some output. The actual problem is that the Estimated BP will always be 0 even if it satisfies the condition.

im-Amitto commented 4 years ago

The current master 46d31d8292ae7217d7a261c8f7e1c2dba5d2b782 will always show the Estimated BPM to be -- irrespective of the calculated value.

afonsocraposo commented 4 years ago

I'm very sorry @im-Amitto! I assumed you were referring to the condition. Regarding the PR. tt was a small mistake of mine. Your PR is totally the way to go ;)

im-Amitto commented 4 years ago

Thanks for such nice repo BTW. I am planning to use it for my upcoming medical app. :)

afonsocraposo commented 4 years ago

You welcome. I recently made some improvements to this. I'm working on committing the changes. When it's done, I'll notify you. Wish you the best!

im-Amitto commented 4 years ago

Thanks in advance

On Tue, 19 May, 2020, 5:17 am Afonso Raposo, notifications@github.com wrote:

You welcome. I recently made some improvements to this. I'm working on committing the changes. When it's done, I'll notify you. Wish you the best!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Afonsocraposo/ppg/pull/2#issuecomment-630492645, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHCHSIT5MMAOFGCPMA4YGYDRSHCKLANCNFSM4NENLOPA .