search

aframevr / a-painter

🎨 Paint in VR in your browser.
https://aframe.io/a-painter/
MIT License
678 stars 202 forks source link

Optimize scene when saving #143

Open feiss opened 8 years ago

feiss commented 8 years ago

A great moment to optimize the scene is when the user saves it. When he does this, we can expect that he is happy with it, so no more undo will be needed before this point.

A good optimization would be packing all (or batches of) strokes of the same brush in just one stroke, dramatically decreasing the number of draw calls.

ngokevin commented 8 years ago

Got report that this drawing took time to load and browser raised unresponsive script error. Most likely a Macbook Air since it loads for me after a time.

https://aframe.io/a-painter/?url=https://ucarecdn.com/5d707ac8-b761-478c-b520-bca1a3d8b5de/

feiss commented 7 years ago

Yup! it takes a while. 300,000 vertices. It seems the author painted slowly so a lot of vertices were created. And I think it's by far the heaviest scene created in A-Painter to date. For comparison, my "You shall not pass" painting is about 80,000 vertices (the guy must have a really good computer..)

blairmacintyre commented 7 years ago

Now that @dmarcos created a component to load scenes into AFrame, this is even more important.