aframevr / a-painter

🎨 Paint in VR in your browser.
https://aframe.io/a-painter/
MIT License
680 stars 200 forks source link

Fix OrbitControls #267

Closed msub2 closed 2 years ago

msub2 commented 2 years ago

OrbitControls causes multiple issues with camera rotation/control. On the regular start page it forces the camera into the ground. On loaded art pages there is strange rotation behavior, the camera goes askew very easily and makes it difficult to navigate. wasd-controls and look-controls seem more than adequete on their own.

dmarcos commented 2 years ago

Looking at pieces using orbit-controls is a much better experience. We can use a camera rig or disable wasd-controls / look-controls when in 2D mode.

msub2 commented 2 years ago

Hmm, I'll try to see if I can get it to behave better, but it wasn't behaving how I expected regular three.js OrbitControls to when I was testing

dmarcos commented 2 years ago

Any success with this? I see this PR has now conflicts. It needs a rebase

msub2 commented 2 years ago

Been a bit busy, but will be looking at this more tonight now that almost everything else is out of the way.

msub2 commented 2 years ago

After lots of trial and error I decided to try out the supermedium aframe-orbit-controls component and finally I got OrbitControls working the way I expected it to. I'm still removing the old orbit controls files, but now we have a working replacement.

dmarcos commented 2 years ago

Thanks!