Open ngokevin opened 5 years ago
FWIW, I definitely support keeping single property, even if it does require the extra step in schema setup.
It's not just an extra step in the schema setup. It became an additional case to handle throughout all of our tools and through the whole core component codebase. You can keep the API effectively the same while ripping out the internals.
Description:
Supporting both single and multi prop schemas have made it so most A-Frame internal-related codepaths (and stuff like Inspector, aframe-react) need to branch and check to support both, often causing bugs.
Also causes API breakages when a component decides to go from single to multi prop.
We can eliminate single-prop schemas.
To support components such as
visible
or perhapsposition
, we can perhaps have components specify a designated "default property". Where if only a plain value is passed intosetAttribute
(e.g.,true
), it will set the designated property.