aframevr / aframe

:a: Web framework for building virtual reality experiences.
https://aframe.io/
MIT License
16.58k stars 3.94k forks source link

VR hands 45 rotation offset on X axes (WebVR) #4719

Open thedart76 opened 3 years ago

thedart76 commented 3 years ago

Description:

Apparently, when using WebVR (Firefox 82.0.3) the VR hands from hand-controls have a 45° rotation offset around the X axes, which doesn't provide correct VR embodiment.

vr-hands-45-rotation-offset-webvr

This seems to be caused by a 43 value on the X axes set in the orientationOffset property of the oculus-touch-controls core component.

( see image below at line 70508)

oculus-touch-controls-root-cause

The issue can be fixed by setting that X value in orientationOffset to 0.

dmarcos commented 3 years ago

Thanks. PRs welcome

thedart76 commented 3 years ago

Done. PR is here: https://github.com/aframevr/aframe/pull/4728