agateblue / django-dynamic-preferences

Dynamic global and instance settings for your django project
https://django-dynamic-preferences.readthedocs.org/
BSD 3-Clause "New" or "Revised" License
350 stars 87 forks source link

python 3.10 removes collections.Mapping #248

Closed mkrogh closed 3 years ago

mkrogh commented 3 years ago

Running django-dynamic-preferences==1.10.1 on python 3.10 fails due to 3.10 removing collections.Mapping.

...
File "/usr/local/lib/python3.10/site-packages/dynamic_preferences/apps.py", line 4, in <module>
    from .registries import preference_models, global_preferences_registry
  File "/usr/local/lib/python3.10/site-packages/dynamic_preferences/registries.py", line 15, in <module>
    from .managers import PreferencesManager
  File "/usr/local/lib/python3.10/site-packages/dynamic_preferences/managers.py", line 8, in <module>
    class PreferencesManager(collections.Mapping):
AttributeError: module 'collections' has no attribute 'Mapping'

Running the same codebase on python 3.9 works just fine.

Other info: Running in docker image for latest python:3 (python:3.10)

jeriox commented 3 years ago

This was already fixed in 1bff8ca7bc0d756eda097dfce59d564f449a5956 but unfortunately @agateblue is not releasing new versions to PyPi anymore, there are several fixes in this repo that don't get reflected in the production version

agateblue commented 3 years ago

Hi there, version 1.11.0 has just been published to PyPi. Things have been hectic over the past year and I haven't been able to maintain the package during that period.

jeriox commented 3 years ago

Thank you very much for your work!

jwaschkau commented 3 years ago

@agateblue Thanks a lot for publishing!

mkrogh commented 3 years ago

@agateblue Yep works on python 3.10 now, thanks for the release :)