agera-edc / MinimumViableDataspace

Guidance on documentation, scripts and integration steps on using the EDC project results
Apache License 2.0
0 stars 2 forks source link

chore: Terraform OIDC #280

Closed algattik closed 1 year ago

algattik commented 1 year ago

What this PR changes/adds

Authenticate Terraform to ARM using Service Principal with Open ID Connect instead of Service Principal with a Client Secret

Why it does that

This simplifies setup and increases security.

Further notes

Support for OpenID Connect was added in version 3.7.0 of the Terraform AzureRM provider.

Linked Issue(s)

Closes https://github.com/eclipse-dataspaceconnector/MinimumViableDataspace/issues/78

Checklist

github-actions[bot] commented 1 year ago

Unit Test Results

  7 files  ±0    7 suites  ±0   44s :stopwatch: +8s 28 tests ±0  27 :heavy_check_mark: ±0  1 :zzz: ±0  0 :x: ±0  31 runs  ±0  30 :heavy_check_mark: ±0  1 :zzz: ±0  0 :x: ±0 

Results for commit 12b067f6. ± Comparison against base commit ce8de659.

:recycle: This comment has been updated with latest results.

codecov-commenter commented 1 year ago

Codecov Report

Base: 78.78% // Head: 78.78% // No change to project coverage :thumbsup:

Coverage data is based on head (5704f25) compared to base (ce8de65). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #280 +/- ## ========================================= Coverage 78.78% 78.78% Complexity 20 20 ========================================= Files 5 5 Lines 66 66 Branches 5 5 ========================================= Hits 52 52 Misses 14 14 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=agera-edc). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=agera-edc)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.