search

agilbert1412 / StardewArchipelago

Archipelago Implementation for Stardew Valley
11 stars 11 forks source link

Mastery Menu fix #76

Closed sharra44 closed 4 months ago

sharra44 commented 4 months ago

Added logic to temporarily set the player mastery state to 0 to allow the claim button to render properly when mastery location has not been claimed yet but the item has been received

agilbert1412 commented 4 months ago

I want to note that I do appreciate the attempt at fixing the bug, and your fix does work, but I found an alternate solution that feels a bit cleaner to me. Since it ended up sharing zero lines of code with yours, I figured it made more sense to implement it and close your PR. I will mention you in the changelog though.

sharra44 commented 4 months ago

Totally makes sense, happy to help and thanks for the credit!

Get Outlook for iOShttps://aka.ms/o0ukef

From: agilbert1412 @.> Sent: Tuesday, July 16, 2024 9:24:15 PM To: agilbert1412/StardewArchipelago @.> Cc: Neely, Sharra @.>; Author @.> Subject: Re: [agilbert1412/StardewArchipelago] Mastery Menu fix (PR #76)

I want to note that I do appreciate the attempt at fixing the bug, and your fix does work, but I found an alternate solution that feels a bit cleaner to me. Since it ended up sharing zero lines of code with yours, I figured it made more sense to implement it and close your PR. I will mention you in the changelog though.

— Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_agilbert1412_StardewArchipelago_pull_76-23issuecomment-2D2232124732&d=DwMFaQ&c=WO-RGvefibhHBZq3fL85hQ&r=hAWehd0QYuobjAfJMWCMNPvqCMdabDxVBr_U6-ta1bg&m=yUx6IEWjyx79FpX-brPdaXFXOcU-n6GAZxADwifeIgJyU6EFr3MkNq2nasTl822V&s=5ZBvRyyy15Py7MdHtY1Cd9VoP_W2NgNNcMKwjtyCLPc&e=, or unsubscribehttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AFN54WJZFAULAIGGSCMU3W3ZMXBT7AVCNFSM6AAAAABKVBLKLWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMZSGEZDINZTGI&d=DwMFaQ&c=WO-RGvefibhHBZq3fL85hQ&r=hAWehd0QYuobjAfJMWCMNPvqCMdabDxVBr_U6-ta1bg&m=yUx6IEWjyx79FpX-brPdaXFXOcU-n6GAZxADwifeIgJyU6EFr3MkNq2nasTl822V&s=f0XXbpXCDOhx1G3c7Lz0q76J5-X5JBO8hZqNJfj1xoA&e=. You are receiving this because you authored the thread.Message ID: @.***>