agilgur5 / react-signature-canvas

A React wrapper component around signature_pad (in < 150 LoC). Unopinionated and heavily updated fork of react-signature-pad
https://agilgur5.github.io/react-signature-canvas/
Other
546 stars 119 forks source link

optim: add `assumptions` to Babel config, mirroring previous config #79

Closed agilgur5 closed 2 years ago

agilgur5 commented 2 years ago

Summary

Optimize output by adding assumptions to the Babel config, which mirrors the previous build system's config that uses Babel 7.

Details

History

I knew the output was different (and larger) due to spec-compliancy changes, but somehow didn't think about adding loose etc as an optimization until I saw Babel's assumptions RFC. I thought I wrote about the output differences in https://github.com/agilgur5/react-signature-canvas/pull/42#pullrequestreview-947783313 , but I guess I didn't? Couldn't find it in a commit message either, but could've sworn I wrote it down somewhere...

codecov[bot] commented 2 years ago

Codecov Report

Merging #79 (09d8d60) into main (b14060c) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##              main       #79   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           75        75           
  Branches         9         9           
=========================================
  Hits            75        75           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b14060c...09d8d60. Read the comment docs.