Vendoring fennel? - Githubissues

jaidetree commented 2 years ago

Just a thought but would it be unreasonable to include fennel source and the other packages we use in the project?

Pros

Static install location
Remove luarocks
More stable, so when fennel updates spacehammer is not broken

Cons

Bigger repo size
Fennel wouldn't be available system-wide, but not sure how common that is for people to use outside of spacehammer?
A script to update those packages would probably be required, but potentially more straight forward than trying to write a package system

If anyone has experience or strong opinions on this, please weigh in!

Grazfather commented 2 years ago

I have thought about this as well. I think it's a good idea. Fennel is intentionally a single file and they encourage its full source inclusion the_Fennel_programming_language .

Grazfather commented 1 year ago

Bump on this. #176 I'd like to update some of our code, but I don't want to force us to update.

Only concern I can think of is if we have users whose configs use module they have installed that might break on an update. That said, fennel is pretty good at maintaining backwards compatibility.

agzam / spacehammer

Vendoring fennel? #169

Pros

Cons