Errors are not passed to metalsmith's done callback

[AndyOGo]

I just realized, that if one file errors, because of wrong pug syntax like:

.correct

buggy*line/throws

This error is not properly handled and passed to done callback, instead it is just ignored...

It is very important to propagate the error so that one could handle it by:

metalsmith.build((err) => {
  if(err) {
    // handle it here
    return
  }
})

Refer to the docs about proper error handling in Node:

• https://nodejs.org/api/errors.html#errors_error_propagation_and_interception
• https://nodejs.org/api/errors.html#errors_node_js_style_callbacks

[ahmadnassri]

this is stemming from the Pug API lacking details on capturing errors: https://pugjs.org/api/reference.html

better error handling is certainly needed, will look into it.

[AndyOGo]

I see. I quickly checked pug's repo. They do not use error-first arguments. Instead they use good old throw. So my guess try, catch is the correct way to do it.

[ahmadnassri]

yep. happy to take PRs, otherwise will add to my backlog.

[AndyOGo]

sure, happy to help out