ahorn / android-rss

Lightweight Android library to parse RSS 2.0 feeds.
528 stars 179 forks source link

Make RSSBase, RSSFeed and RSSItem Parcelable #27

Open Maragues opened 9 years ago

Maragues commented 9 years ago

To avoid requests on orientation change, being able to Parcel this items would make things easier.

I can make the PR, but it's terrible to still work on a Eclipse project structure :(

ahorn commented 9 years ago

[I]t's terrible to still work on a Eclipse project structure

What is being used these days?

Maragues commented 9 years ago

http://developer.android.com/tools/studio/index.html

Also, Android now uses Gradle as its build system

ahorn commented 9 years ago

Looks interesting. If you want to setup a build as described above, I'd accept a patch.

Maragues commented 9 years ago

Hi ahorn, I'm afraid I've decided to not use your library, since it wasn't parsing correctly a RSS feed.

Still, if you open the project with Android Studio, it shouldl automatically transform it to the gradle structure. Good luck!

ahorn commented 9 years ago

Okay. Out of curiosity, which feed? What library are you using instead?

Maragues commented 9 years ago

Oh, actually I messed up and I am using your library, only I'm not trying to parcel items :-) I ditched another one (https://github.com/Pkmmte/PkRSS) that did have parsing problems.

If I have time I'll try to make the PR

ahorn commented 9 years ago

As far as I know, PkRSS uses an XML pull parser. By contrast, android-rss uses SAX. According to @steveliles, SAX parsing on Android is an order of magnitude faster than other parsing techniques [1].

If you find android-rss helpful, great. And if want to fix any issues here or there (including the build), any patches are of course warmly welcome.

[1] https://github.com/steveliles/dsl4xml-perf

ahorn commented 8 years ago

Hi, how is this going?

ahorn commented 8 years ago

Hi there, I hope this finds you well. May I close this issue?

Maragues commented 8 years ago

This week i may have time, sorry for the delay El 8/8/2015 0:35, "ahorn" notifications@github.com escribió:

Hi there, I hope this finds you well. May I close this issue?

— Reply to this email directly or view it on GitHub https://github.com/ahorn/android-rss/issues/27#issuecomment-128848888.

ahorn commented 8 years ago

Cool!

Maragues commented 8 years ago

Hi, unfortunately Android Studio does not convert the project automatically, thus I should devote more time than I can allocate.

Anyway this should be a very straightforward implementation.

You can even use this website that automatically converts a class to parcelable

http://www.parcelabler.com/

On Sat, Aug 8, 2015 at 11:09 AM, ahorn notifications@github.com wrote:

Cool!

— Reply to this email directly or view it on GitHub https://github.com/ahorn/android-rss/issues/27#issuecomment-128942760.

ahorn commented 8 years ago

Thanks for looking into this. I am afraid though I don't have time either. Should I close the issue?

ahorn commented 6 years ago

Hi @Maragues

For some time now, I wanted to update the README with references to projects/products that are using android-rss. If it's okay for this information to be public, I would be grateful if you could share the project name or product (if any) that is using android-rss.

Many thanks in advance.