Closed monilpat closed 4 days ago
Very cool but we should think about adding this to the db
Very cool but we should think about adding this to the db
Thanks for the review - yeah totally the csv was an interim patch, it definitely should be part of the db :)
Relates to:
Issue: Ensure dynamic parsing, validation, and execution for mass payouts using Coinbase SDK.
Risks
Risk Level: Medium
Background
What does this PR do?
This PR implements dynamic mass payout capabilities using the Coinbase SDK. Key updates include:
transferTemplate
details to dynamically construct transactions for processing.receivingAddresses
,network
) to ensure they comply with supported formats and networks.src/plugins/transactions.csv
.characters/charactername.character.json
undersettings.secrets
.character-seed.txt
file, and a note is added to move these details manually to the character's settings or environment variables.What kind of change is this?
Improvements: Adds dynamic appending and parsing of CSV data.
Features: Introduces mass payouts using Coinbase SDK for supported networks.
Documentation changes needed?
Yes. The changes require an update to project documentation to reflect:
transferTemplate
structure for mass payouts.base
,sol
,eth
,arb
,pol
).COINBASE_API_KEY
andCOINBASE_PRIVATE_KEY
.character-seed.txt
tosettings.secrets
or.env
).Testing
Where should a reviewer start?
massPayoutProvider.get
function for dynamic parsing and handling of CSV records.executeMassPayout
logic for sequential processing of transactions.Detailed testing steps
Setup Environment Variables:
COINBASE_API_KEY
andCOINBASE_PRIVATE_KEY
are set in the.env
file or runtime settings.Process Mass Payout Transactions:
SEND_MASS_PAYOUT
action.Wallet Generation:
COINBASE_GENERATED_WALLET_HEX_SEED
andCOINBASE_GENERATED_WALLET_ID
from your configuration.characters/charactername.character.json
undersettings.secrets
.charactername-seed.txt
with instructions to move them manually.Validate Edge Cases:
Screenshots
https://drive.google.com/file/d/160rreXAoKBj9db8lIMjF5LW8EmAihQmi/view?usp=sharing
After
Screen Recording:
Deploy Notes
src/plugins/transactions.csv
is accessible.Database changes
Deployment instructions
[Discord](https://discord.gg/ai16z) username
0x8664