search

aiidalab / aiidalab-widgets-base

Reusable widgets for AiiDAlab applications
MIT License
7 stars 17 forks source link

Discard module file from static styles folder #632

Closed edan-bainglass closed 2 months ago

edan-bainglass commented 2 months ago

Replaced module loading with using direct path in #624

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 83.49%. Comparing base (ce9cfe9) to head (b925206).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #632 +/- ## ======================================= Coverage 83.49% 83.49% ======================================= Files 17 17 Lines 3539 3539 ======================================= Hits 2955 2955 Misses 584 584 ``` | [Flag](https://app.codecov.io/gh/aiidalab/aiidalab-widgets-base/pull/632/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidalab) | Coverage Δ | | |---|---|---| | [python-3.11](https://app.codecov.io/gh/aiidalab/aiidalab-widgets-base/pull/632/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidalab) | `83.49% <0.00%> (ø)` | | | [python-3.9](https://app.codecov.io/gh/aiidalab/aiidalab-widgets-base/pull/632/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidalab) | `83.53% <0.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidalab#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

edan-bainglass commented 2 months ago

Interesting. So the __init__.py file is required in static/styles even though it is no longer used as a module. This is because without it, the styles directory does not transfer to site-packages on install, and hence is not found by the loader. Thanks @superstar54 for assisting in debugging this.